Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename replaceExistingSynonyms to clearExistingSynonyms #1224

Closed
chloelbn opened this issue Nov 13, 2020 · 0 comments · Fixed by #1226
Closed

Rename replaceExistingSynonyms to clearExistingSynonyms #1224

chloelbn opened this issue Nov 13, 2020 · 0 comments · Fixed by #1226

Comments

@chloelbn
Copy link
Contributor

The parameter replaceExistingSynonyms in the saveSynonyms method is inconsistent with the rest of our API. We should rename it to clearExistingSynonyms. Backward-compatibility should be kept in mind
Haroenv added a commit that referenced this issue Nov 16, 2020
@Haroenv
feat(saveSynonyms): replaceExistingSynonyms -> clearExistingSynonyms
4091d67 
fixes #1224
@Haroenv Haroenv mentioned this issue Nov 16, 2020
Merged
Haroenv added a commit that referenced this issue Nov 18, 2020
@Haroenv
feat(saveSynonyms): replaceExistingSynonyms -> clearExistingSynonyms (#…
2fcf485 
…1226)

fixes #1224
This was referenced Mar 10, 2021
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@chloelbn