Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recommend): add "Looking Similar" model #1469

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Conversation

raed667
Copy link
Contributor

@raed667 raed667 commented Jul 10, 2023

Implement Recommend looking-similar model.

Beyond the model name, everything else should work exactly as other recommend models such as related products.

@raed667 raed667 requested a review from marialungu July 10, 2023 07:51
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5ec2f38:

Sandbox Source
javascript-client-app Configuration

Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess regarding failing tests is that they are just really flaky. I looked into merged PRs and all their pipelines are retried a few time until they go green.

packages/recommend/src/methods/getLookingSimilar.ts Outdated Show resolved Hide resolved
lerna.json Outdated Show resolved Hide resolved
raed667 and others added 2 commits July 13, 2023 21:51
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
@raed667 raed667 marked this pull request as ready for review July 17, 2023 13:51
@raed667 raed667 requested a review from dhayab July 17, 2023 14:59
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great :) do you plan on adding it to the generated clients too?

Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍.

Regarding the RC release, as this addition follows closely how other methods are defined, I think it can be released directly in a minor as part of the monorepo release process.

If you prefer having an RC/Beta release, you should not merge this branch, and we can instead perform a manual release (or perhaps there's another process owners can guide us through).

@raed667
Copy link
Contributor Author

raed667 commented Jul 18, 2023

@shortcuts indeed we should this to the generated clients as well 👍

@dhayab No beta/RC needed, once merged this should probably be simply released under 4.19.0

@shortcuts
Copy link
Member

@shortcuts indeed we should this to the generated clients as well 👍

cool! let me know if you need help contributing to the specs

@shortcuts shortcuts merged commit 01eac7f into master Jul 18, 2023
8 checks passed
@shortcuts shortcuts deleted the feat/looking-similar branch July 18, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants