Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose rule.consequence.promote.objectIDs string array #1155

Closed
aseure opened this issue May 20, 2020 · 2 comments · Fixed by #1156
Closed

Expose rule.consequence.promote.objectIDs string array #1155

aseure opened this issue May 20, 2020 · 2 comments · Fixed by #1156
Labels
on hold

Comments

@aseure
Copy link
Contributor

aseure commented May 20, 2020

On top of the existing objectID (singular) string field, a new objectIDs
(plural) string array field is now be exposed in the rule.consequence.promote
Rule object representation. This lets the user easily promote a full group of
objects without letting some priority conflicts to shift some objects at the end
of the promoted object list.
@Haroenv
Copy link
Contributor

Haroenv commented May 20, 2020

looks like we only accept objectID (singular) now: https://github.com/algolia/algoliasearch-client-javascript/blob/master/packages/client-search/src/types/Rule.ts#L84

Haroenv added a commit that referenced this issue May 20, 2020
@Haroenv
feat(rule): add group promotes
5884a81 
doesn't have a test yet, but allows you to base on top of this.

fixes #1155
@Haroenv Haroenv mentioned this issue May 20, 2020
Merged
nunomaduro pushed a commit that referenced this issue Jun 9, 2020
@Haroenv @nunomaduro
feat(rule): add group promotes
bd5b010 
doesn't have a test yet, but allows you to base on top of this.

fixes #1155
nunomaduro pushed a commit that referenced this issue Jun 9, 2020
@Haroenv @nunomaduro
feat(rule): add group promotes
c63dda9 
doesn't have a test yet, but allows you to base on top of this.

fixes #1155
@nunomaduro
Copy link
Contributor

This feature can't be merged yet: algolia/algoliasearch-client-specs-internal#118.

Haroenv added a commit that referenced this issue Aug 6, 2020
@Haroenv @nunomaduro
feat(rule): add group promotes (#1156)
7c37289 
* feat(rule): add group promotes

doesn't have a test yet, but allows you to base on top of this.

fixes #1155

* prettier

* chore(group-promotes): fixes object ids readonly type

Co-authored-by: Nuno Maduro <enunomaduro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rule): add group promotes algolia/algoliasearch-client-javascript
3 participants
@aseure @nunomaduro @Haroenv