feat(rule): add group promotes #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
commented
May 20, 2020
| /** | ||
| * Promoted start rank for the objects (zero-based). | ||
| */ | ||
| readonly position: number; |
There was a problem hiding this comment.
in principle we could have this in a shared type, but I wanted a different description for position if matched with an array
nunomaduro
force-pushed
the
Haroenv-patch-2
branch
from
898d4cd
to
62f6ef0
Compare
doesn't have a test yet, but allows you to base on top of this. fixes #1155
nunomaduro
force-pushed
the
Haroenv-patch-2
branch
from
62f6ef0
to
850abeb
Compare
|
This feature can't be merged yet: https://github.com/algolia/algoliasearch-client-specs-internal/issues/118. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesn't have a test yet, but allows you to base on top of this.
fixes #1155
see: https://www.algolia.com/doc/api-reference/api-methods/save-rule/#method-param-objectids