Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client-analytics): A/B Test VariantResponse typing #1185

Merged
merged 1 commit into from
Aug 22, 2020
Merged

fix(client-analytics): A/B Test VariantResponse typing #1185

merged 1 commit into from
Aug 22, 2020

Conversation

kombucha
Copy link
Contributor

  • Fixed typo: averageClickPostion -> averageClickPosition
  • Added missing attribute trackedSearchCount

Screenshot 2020-08-22 at 11 07 46

@kombucha kombucha added the TypeScript Problems related to TypeScript definitions label Aug 22, 2020
@kombucha kombucha changed the title fix: a/b test VariantResponse typing fix(client-analytics): a/b test VariantResponse typing Aug 22, 2020
@kombucha kombucha changed the title fix(client-analytics): a/b test VariantResponse typing fix(client-analytics): A/B Test VariantResponse typing Aug 22, 2020
@Haroenv Haroenv merged commit c45fa4c into master Aug 22, 2020
@Haroenv Haroenv deleted the kombucha-patch-1 branch August 22, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
TypeScript Problems related to TypeScript definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kombucha @Haroenv