Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): add the attributesToTransliterate setting #1244

Merged
merged 3 commits into from Jan 19, 2021

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jan 15, 2021

fixes #1243

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c415ce0:

Sandbox Source
javascript-client-app Configuration

Copy link
Contributor

@chloelbn chloelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this attribute is only applied when your query language is Japanese

@Haroenv
Copy link
Contributor Author

Haroenv commented Jan 19, 2021

doesn't "for compatible scripts" imply that already? @chloelbn

@chloelbn
Copy link
Contributor

@Haroenv indeed! I didn't get that with the wording sorry.

chloelbn
chloelbn previously approved these changes Jan 19, 2021
Co-authored-by: remy-zeiss <46535273+remy-zeiss@users.noreply.github.com>
@Haroenv Haroenv merged commit b91c035 into master Jan 19, 2021
@Haroenv Haroenv deleted the feat/attributesToTransliterate branch January 19, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(settings): add attributesToTransliterate settings
3 participants