add searchFacet feature #166
Conversation
maxiloc
force-pushed
the
search-in-facets
branch
4 times, most recently
from
cabc423
to
d3741ee
Compare
| @@ -510,6 +510,26 @@ public function search($query, $args = null) | |||
| ); | |||
| } | |||
|
|
|||
| public function searchFacet($facetName, $facetQuery, $query = null) | |||
There was a problem hiding this comment.
If it was $query = array() the condition $query === null could be omitted
There was a problem hiding this comment.
I asked myself the same question. I took the same code that what we have for search, we can change it for sure
| // not fatal | ||
| } | ||
| try { | ||
| $this->client->deleteIndex($this->safe_name('àlgol?à2-php')); |
There was a problem hiding this comment.
Why àlgol?à2-php index is deleted in this test, when it's not used for the real test?
| $this->index->waitTask($task['taskID']); | ||
|
|
||
| # Straightforward search. | ||
| $facetHits = $this->index->searchFacet('series', 'Hobb')['facetHits']; |
There was a problem hiding this comment.
Accessing array elements right after method call is supported since 5.4. The test will fail on 5.3
maxiloc
force-pushed
the
search-in-facets
branch
4 times, most recently
from
cf33400
to
78c6029
Compare
|
I rebased based on the comment |
|
|
||
| public function testSearchTest() | ||
| { | ||
| $settings = [ |
There was a problem hiding this comment.
Short array syntax fails on 5.3
maxiloc
force-pushed
the
search-in-facets
branch
2 times, most recently
from
39154ff
to
e8ca08b
Compare
| $this->assertEquals($facetHits[0]['count'], 2); | ||
|
|
||
| # Using an addition query to restrict search. | ||
| $query = [ |
There was a problem hiding this comment.
Still bad array syntax :))
|
Changes Unknown when pulling e8ca08b on search-in-facets into * on master*. |
maxiloc
force-pushed
the
search-in-facets
branch
from
e8ca08b
to
3665798
Compare
|
Should be good now |
|
Changes Unknown when pulling 3665798 on search-in-facets into * on master*. |
1 similar comment
|
Changes Unknown when pulling 3665798 on search-in-facets into * on master*. |
No description provided.