Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ::class instead of string for class name #667

Merged
merged 2 commits into from May 4, 2021
Merged

fix: use ::class instead of string for class name #667

merged 2 commits into from May 4, 2021

Conversation

matzeeable
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Need Doc update no

Describe your change

Use the ::class identifier to get the full qualified name for a class instead of a string.

What problem is this fixing?

I want to bundle this package within my WordPress plugin together with PHP-Scoper, unfortunately it does not scope a function within functions.php correctly.

PHP-Scoper is a tool which essentially moves any body of code, including all dependencies such as vendor directories, to a new and distinct namespace.

PHP-Scoper does currently not support scoping array callbacks, see also humbug/php-scoper#294

@matzeeable matzeeable changed the title fix: use ::class instead of string for class name fix: use ::class instead of string for class name Feb 25, 2021
@chloelbn
Copy link
Contributor

chloelbn commented Apr 5, 2021

Hi @matzeeable ! could you try and rebase on master please to see if this fixes the tests in the CI? Thanks

@matzeeable
Copy link
Contributor Author

Hey @chloelbn ! Just rebased from upstream, unfortunately the CI failed again. Can you please check what happens here? I think the code changes shouldn't be the problem. :-)

@chloelbn
Copy link
Contributor

chloelbn commented Apr 23, 2021

Hi @matzeeable ! Indeed we need to solve this issue for the CI for ext contributors. I'll run your PR locally and merge it without the CI is everything goes fine. Could you just fix the conflict please? Thanks!

@matzeeable
Copy link
Contributor Author

Hey @chloelbn ! Just resolved the conflict :-)

@chloelbn chloelbn merged commit b48f1e2 into algolia:master May 4, 2021
@matzeeable matzeeable deleted the patch-1 branch May 25, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants