Remove invalid method call #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failures seem unrelated (429 too many attempts?) |
|
I am also randomly receiving the following error: Using the following versions on PHP 7.4 |
|
@chloelbn please review |
When a connection fails, there cannot be a response: the client would have to be connected to get one. Therefore, it would make no sense to have a hasResponse() method on ConnectException.
chloelbn
force-pushed
the
stop-attempting-to-get-response-from-connect-exception
branch
from
12def50
to
8c510f0
Compare
Merged
|
I've opened another PR to workaround the CI failing; we'll fix this another way and we'll be able to move forward! |
greg0ire
deleted the
stop-attempting-to-get-response-from-connect-exception
branch
|
@chloelbn I think closing and reopening this PR would have been enough: In general, CI usually runs against a merge of the target and the source branch (not sure if that's the case with Circle CI though). So in theory, when reopening, a new merge would have been performed, with the new commit on master that contains your fix 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
I'm removing a call to existent method
ConnectException::hasResponse()When a connection fails, there cannot be a response: the client would
have to be connected to get one. Therefore, it would make no sense to
have a
hasResponse()method onConnectException.What problem is this fixing?
This fixes a crash that can happen in case of connection issues.