Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use interface for constructor arguments #704

Merged
merged 1 commit into from Jul 6, 2022
Merged

Use interface for constructor arguments #704

merged 1 commit into from Jul 6, 2022

Conversation

loevgaard
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Related Issue Fix #...
Need Doc update no

Describe your change

Using interface for constructor arguments in clients that wasn't updated when introducing interface

What problem is this fixing?

This allows developers to easily mock the clients (and the underlying APIWrapper)

@loevgaard
Copy link
Contributor Author

@maxiloc, @speedblue, @nunomaduro, @julienbourdeau, @chloelbn: Can any of you merge this? :)

damcou
damcou approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having spotted this :)

@damcou damcou merged commit a8f0326 into algolia:master Jul 6, 2022
@loevgaard loevgaard deleted the interface branch July 6, 2022 13:28
@BackEndTea BackEndTea mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loevgaard @damcou