Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recommendation)!: remove recommendation client in favor of personalization #554

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Feb 24, 2023

Q A
Bug fix? no
New feature? no
BC breaks? yes
Related Issue Fix #...
Need Doc update no

Describe your change

https://algolia.atlassian.net/browse/DI-1010

Months years ago we added a deprecation notice for the recommendation client, since we will now release a new major, we can remove anything related to this client.

deprecation PR #536

@shortcuts shortcuts self-assigned this Feb 24, 2023
@millotp millotp changed the title fix(recommendation)!: remove recommendation client in favor of personalization fix(recommendation): remove recommendation client in favor of personalization Feb 24, 2023
@shortcuts shortcuts changed the title fix(recommendation): remove recommendation client in favor of personalization fix(recommendation)!: remove recommendation client in favor of personalization Feb 24, 2023
@@ -61,6 +62,13 @@ commands =
black --check algoliasearch/ tests/
flake8 algoliasearch/ tests/

[testenv:format-fix]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this caused a lot of changes so I've moved it to #555

Copy link

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 recommendation client

@shortcuts shortcuts merged commit 639cac8 into master Feb 24, 2023
@shortcuts shortcuts deleted the fix/remove-recommendation-client branch February 24, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants