Skip to content

Commit

Permalink
chore: stop using coveralls because of a GPL-licensed transitive dep
Browse files Browse the repository at this point in the history
Our `coveralls` development dependency imports the `term-ansicolor`
dependency. This dependency is licensed under GPLv2 which we do not want
to use as it would make our users' projects subject to GPL limitations.

To counter that, we tried enforce the `term-ansicolor` dependency to
`1.6.0`.  As of this version, this dependency is using an Apache 2.0
license which is compatible with both non-GPL and GPL users' projects.

However, because `term-ansicolor` as of `1.6.0` is not compatible with
Ruby 1.x versions, the last solution is to completely get rid of
`coveralls`.

[changelog]
  • Loading branch information
aseure committed Jul 18, 2019
1 parent 01e19dc commit d2fbe8c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ else
end

group :development do
gem 'coveralls'
gem 'rake'
gem 'rdoc'
gem 'travis'
Expand Down
5 changes: 0 additions & 5 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@
SimpleCov.start
end

if ENV['TRAVIS'] && Object.const_defined?(:RUBY_ENGINE) && RUBY_ENGINE == 'ruby'
require 'coveralls'
Coveralls.wear!
end

require 'bundler/setup'

Bundler.setup :test
Expand Down

0 comments on commit d2fbe8c

Please sign in to comment.