Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request): Add request options #394

Merged
merged 1 commit into from Aug 16, 2017
Merged

Conversation

ElPicador
Copy link
Contributor

No description provided.

Copy link
Contributor

@clement-leprovost clement-leprovost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't speak Scala, so there is no way that I can review that meaningfully. :/

Copy link
Contributor

@aseure aseure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I only have two questions though:

  1. Should we standardize the naming of the extra/custom headers/URL parameters (some PRs use extra whereas others use custom)

  2. What does type T = ... do at the beginning of every case class ...Definition?

@ElPicador
Copy link
Contributor Author

The T is the type of return of the methods.
This way you parametrize a class with itself, so every overloaded method returns it's own type

@ElPicador
Copy link
Contributor Author

for the extra/custom, I have no opinion. Maybe @clement-leprovost has one?

@clement-leprovost
Copy link
Contributor

I like "extra" better, because everything in the request options is already "custom". :)

@ElPicador ElPicador merged commit 61a06ba into master Aug 16, 2017
@ElPicador ElPicador deleted the feat/request_options branch August 16, 2017 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants