fixed: Ensure that the DnsNameResolver is closed when the AlgoliaClient is #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseure
changed the title
Ant-hem
force-pushed
the
close-dns-resolver-properly
branch
from
2260010
to
6b937d8
Compare
Ant-hem
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Make sure that
DnsNameResolver.close()is called when theAlgoliaClient.close()is called.What problem is this fixing?
Problem is better described in #500 but essentially, prior to that fix, sockets were leaked and could lead to exhaustion when many
AlgoliaClientgot instantiated in the same JVM.@Ant-hem @ElPicador If you guys could help me know how to run a single ScalaTest with specific JVM options, I'd be happy to know because I couldn't find an easy way of doing so to integrate the test suggested by @tanin47 in his issue. Thanks in advance for any help.