fix: tagged string subrange calculation crash #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VladislavFitz
commented
Sep 14, 2020
•
VladislavFitz
commented
- Fix crash caused by the calculation of the tagged subranges in case of nested tags (Tagged string subrange calculation crash in case of nested string #662)
- Add multiple new tagged string calculation test cases
- Add TaggedString documentation
VladislavFitz
changed the title
VladislavFitz
changed the title
…unexpected extra tags. Add convenient functions for extracting tagged/untagged substrings
VladislavFitz
force-pushed
the
fix/html-highlighting-issue
branch
from
f2be13b
to
9a18794
Compare
aallam
approved these changes
Nov 17, 2020
spinach
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.