Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(facet ordering): Dynamic facet ordering support #739

Merged
merged 22 commits into from
Jul 5, 2021
Merged

feat(facet ordering): Dynamic facet ordering support #739

merged 22 commits into from
Jul 5, 2021

Conversation

VladislavFitz
Copy link
Contributor

@VladislavFitz VladislavFitz commented Apr 14, 2021 •
edited
Loading

Summary

Introduces the models for dynamic facet ordering support

@VladislavFitz VladislavFitz requested a review from aallam June 7, 2021 07:37
@VladislavFitz VladislavFitz marked this pull request as ready for review June 7, 2021 07:37
@VladislavFitz VladislavFitz changed the title feat: Dynamic facet order support feat: Dynamic facet ordering support Jun 10, 2021
Haroenv
Haroenv reviewed Jun 10, 2021
View reviewed changes
Copy link

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema looks correct

Sources/AlgoliaSearchClient/Command/AlgoliaCommand.swift Show resolved Hide resolved
Sources/AlgoliaSearchClient/Models/Rule/RenderingContent.swift Outdated Show resolved Hide resolved
...t/Models/Search/Response/SearchResponse/Auxiliary/RenderingContent/FacetOrderContainer.swift Outdated Show resolved Hide resolved
...SearchClient/Models/Search/Response/SearchResponse/Auxiliary/RenderingContent/Redirect.swift Outdated Show resolved Hide resolved
Haroenv
Haroenv approved these changes Jun 10, 2021
View reviewed changes
Copy link

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my approval is only for the shape of the result / rule, I wouldn't know enough swift for the other areas of the code

@VladislavFitz
Copy link
Contributor Author

my approval is only for the shape of the result / rule, I wouldn't know enough swift for the other areas of the code

Sure, waiting for @aallam approval.

@VladislavFitz VladislavFitz changed the title feat: Dynamic facet ordering support feat(facet ordering): Dynamic facet ordering support Jul 5, 2021
@VladislavFitz VladislavFitz merged commit f126829 into master Jul 5, 2021
@VladislavFitz VladislavFitz mentioned this pull request Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

@aallam aallam aallam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VladislavFitz @aallam @Haroenv