Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/reindex deletes settings #239

Merged
merged 3 commits into from Jan 16, 2018
Merged

Fix/reindex deletes settings #239

merged 3 commits into from Jan 16, 2018

Conversation

PLNech
Copy link
Member

@PLNech PLNech commented Jan 12, 2018

Addresses #238 by ensuring we keep existing settings if any.

@PLNech
Copy link
Member Author

PLNech commented Jan 12, 2018

Testing 831eeec locally succeeds everywhere but with django19:

  py27-django17: commands succeeded
  py33-django17: commands succeeded
  py34-django17: commands succeeded
  py27-django18: commands succeeded
  py33-django18: commands succeeded
  py34-django18: commands succeeded
  py35-django18: commands succeeded
  py36-django18: commands succeeded
  py27-django19: commands succeeded
ERROR:   py34-django19: commands failed
ERROR:   py35-django19: commands failed
ERROR:   py36-django19: commands failed
  coverage: commands succeeded

On django19, test_index_model_with_foreign_key_reference fails with this error:

Traceback (most recent call last):
  File "/Users/pln/Work/APIClients/algoliasearch-django/tests/test_index.py", line 65, in test_index_model_with_foreign_key_reference
    index.reindex_all()
  File "/Users/pln/Work/APIClients/algoliasearch-django/algoliasearch_django/models.py", line 424, in reindex_all
    if "Index does not exist" in e.message:
AttributeError: 'AlgoliaException' object has no attribute 'message'

Currently Investigating this error.

@PLNech PLNech merged commit ca73b3b into master Jan 16, 2018
@PLNech PLNech deleted the fix/reindex_deletes_settings branch January 16, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant