This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
fix(v3): Stop throwing deprecation warning when using Jekyll v3 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelastic
force-pushed
the
fix/jekyll-v3
branch
6 times, most recently
from
900669c
to
be7c6fd
Compare
|
Haha, will fix that later. |
|
|
This should fix the deprecation warnings the plugin is throwing with Jekyll 3.0.
```
Deprecation: Document#slug is now a key in the #data hash.
Called by /home/tim/.rvm/gems/ruby-2.2.3/gems/algoliasearch-jekyll-0.5.3/lib/record_extractor.rb:35:in `metadata'.
Deprecation: Document#tags is now a key in the #data hash.
Called by /home/tim/.rvm/gems/ruby-2.2.3/gems/algoliasearch-jekyll-0.5.3/lib/record_extractor.rb:53:in `tags'.
```
I've fighted hard, but we can now launch the tests for both Jekyll 2.5 and Jekyll 3.0 (everything is in `./scripts`), and write tests conditionnaly for one version or the other.
The tool to do that is [appraisal](https://github.com/thoughtbot/appraisal) that lets you define several Gemfiles, and you then have to prefix all your `bundle` commands with `appraisal` (so, yeah, you end up with silly `appraisal bundle exec rake stuff`).
I had to duplicate the fixtures, for each version, which explain the large number of file changed, but this is just a copy paste (except the `_config.yml` that is different for each jekyll version)
pixelastic
force-pushed
the
fix/jekyll-v3
branch
from
b083da0
to
2a2d9bb
Compare
pixelastic
added a commit
that referenced
this pull request
Jan 11, 2016
fix(v3): Stop throwing deprecation warning when using Jekyll v3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the deprecation warnings the plugin is throwing with Jekyll 3.0.
I've fighted hard, but we can now launch the tests for both Jekyll 2.5 and Jekyll 3.0 (everything is in
./scripts), and write tests conditionnaly for one version or the other.The tool to do that is appraisal that lets you define several Gemfiles, and you then have to prefix all your
bundlecommands withappraisal(so, yeah, you end up with sillyappraisal bundle exec rake stuff).I had to duplicate the fixtures, for each version, which explain the large number of file changed, but this is just a copy paste (except the
_config.ymlthat is different for each jekyll version)Fixes #14