This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
feat(error): Display human error when API key ACL is not enough #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelastic
force-pushed
the
fix/18-key-acl
branch
from
15425a9
to
7870f2c
Compare
pixelastic
force-pushed
the
fix/18-key-acl
branch
from
7870f2c
to
7005983
Compare
|
\o/ |
pixelastic
added a commit
that referenced
this pull request
Jan 13, 2016
feat(error): Display human error when API key ACL is not enough
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've mostly added an ErrorHandler that groups all the error-related functions, including one that can parse the Algolia error messages in ordre to provide context-aware and more friendly error messages.
I've update the gemspec (in order to test the plugin in a real project)
I've also fixed a few misconfiguration with Appraisal. Running Guard will stop restarting the whole Appraisal process, Guard is now actually run from inside an Appraisal context. I've also set jekyll 2.5 as the defaul version (in Gemfile) and update it in specific Appraisals.