This repository has been archived by the owner on Mar 21, 2018. It is now read-only.

Add a config option for extra extensions to index #60

Merged

redox merged 1 commit into algolia:develop from advancedtelematic:feat/support-jekyll-asciidoc

Oct 15, 2017

Contributor

tkfu commented Sep 27, 2017 •

edited by Haroenv

Loading

Jekyll can be extended to parse file formats other than markdown.
However, jekyll algolia push ignores them by default. This adds
a config option to specify additional extensions to be indexed.

fixes #61

tkfu mentioned this pull request

Asciidoc files don't get indexed #61

Closed

coveralls commented Sep 27, 2017 •

edited

Loading

Changes Unknown when pulling bc340f0 on advancedtelematic:feat/support-jekyll-asciidoc into ** on algolia:develop**.

1 similar comment

coveralls commented Sep 27, 2017

Changes Unknown when pulling bc340f0 on advancedtelematic:feat/support-jekyll-asciidoc into ** on algolia:develop**.

Contributor Author

tkfu commented Sep 27, 2017

Note: The TravisCI failures are also there on the base branch.

Haroenv requested a review from pixelastic

September 27, 2017 15:32

Haroenv reviewed

View reviewed changes

Contributor

Haroenv left a comment

This seems very good! thanks

Contributor Author

tkfu commented Oct 12, 2017 •

edited

Loading

Any update on this @pixelastic? I need this (or some other solution to #61) merged, and an updated version of the gem to be available, before I can actually start using algolia.

Contributor

Haroenv commented Oct 12, 2017

Hey @tkfu, sorry for not being reactive faster, seems like this throws a deprecation warning on Jekyll 3, can you take a look at that?

Contributor Author

tkfu commented Oct 12, 2017 •

edited

Loading

It's because your develop branch is 15 commits behind master, and one of the missing commits is the one that fixed the deprecation warning. I could rebase this on master and make a PR to master instead, if you like?

Contributor

Haroenv commented Oct 12, 2017

I updated develop to contain the fix 😄


          Add a config option for extra extensions to index

3d640d0

Jekyll can be extended to parse file formats other than markdown.
However, `jekyll algolia push` ignores them by default. This adds
a config option to specify additional extensions to be indexed.

tkfu force-pushed the feat/support-jekyll-asciidoc branch from bc340f0 to 3d640d0 Compare

October 13, 2017 09:42

Contributor Author

tkfu commented Oct 13, 2017

I rebased and pushed--tests should now be passing.

coveralls commented Oct 13, 2017 •

edited

Loading

Coverage remained the same at 100.0% when pulling 3d640d0 on advancedtelematic:feat/support-jekyll-asciidoc into 93b95dd on algolia:develop.

4 similar comments

coveralls commented Oct 13, 2017 •

edited

Loading

Coverage remained the same at 100.0% when pulling 3d640d0 on advancedtelematic:feat/support-jekyll-asciidoc into 93b95dd on algolia:develop.

coveralls commented Oct 13, 2017

Coverage remained the same at 100.0% when pulling 3d640d0 on advancedtelematic:feat/support-jekyll-asciidoc into 93b95dd on algolia:develop.

coveralls commented Oct 13, 2017

Coverage remained the same at 100.0% when pulling 3d640d0 on advancedtelematic:feat/support-jekyll-asciidoc into 93b95dd on algolia:develop.

coveralls commented Oct 13, 2017

Coverage remained the same at 100.0% when pulling 3d640d0 on advancedtelematic:feat/support-jekyll-asciidoc into 93b95dd on algolia:develop.

Haroenv approved these changes

View reviewed changes

redox merged commit 4e6b034 into algolia:develop

Contributor

redox commented Oct 15, 2017

Released and part of 0.9.0

Contributor

pixelastic commented Oct 30, 2017

Thanks @tkfu for the PR and thanks @redox and @Haroenv for taking care of the merge + release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.