Bugfix/mage 773 improved category anchor #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt premature truncation of available categories while determining root path
mohitalgolia
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that manually anchoring the
hiearchicalMenuwidget viatransformItemsfails when the number of categories exceeds the limit defined.The result is an inexplicable category menu that does not appear to match the data on browse (in this case the category menu should not appear at all because "Jackets" is at the deepest level):
A simpler approach is available via the core InstantSearch API - which has been tested to work with
algoliaConfig.request.pathfor both browse and search operations.