Bugfix/mage 792 - categoryPageId serialization fix #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update module version
release/3.11.0
Updated changelog
…e-duplication so that json_encode does not serialize to a keyed object in the Algolia index
rachel-trott
approved these changes
Nov 6, 2023
mohitalgolia
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a critical fix for serialization of arrays that have been deduplicated leaving gaps in the key sequence.
json_encodewill serialize an array as a JSON object when the array keys are not consecutive.Because the scenario does not happen for every product only certain objects in the Algolia index may manifest this behavior. This can create a problem for Algolia features such as visual merchandising which require a scalar array to function as a category page ID and not an object and mixed data types can result in the index.
Further details will be supplied in the corresponding Jira ticket.