Duplicate Replica Issue one set is standard and another is virtual #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge develop branch
…MAGE-797 Duplicate Replica Issue one set is standard and another is virtual
mohitalgolia
changed the title
cammonro
reviewed
Feb 12, 2024
There was a problem hiding this comment.
@rachel-trott @mohitalgolia Please see my comments with regards to release 3.13.2
Note that this PR closely relates to #1421
| @@ -1558,17 +1558,19 @@ public function handlingReplica($indexName, $storeId, $sortingAttribute = false) | |||
| return $sortingIndex['name']; | |||
| }, $sortingIndices)); | |||
| try { | |||
| $replicasFormated = $this->handleVirtualReplica($replicas); | |||
| $availableReplicaMatch = array_merge($replicasFormated, $replicas); | |||
There was a problem hiding this comment.
This can cause an "Array to string conversion" failure when updating replica config. This must be tested across multiple scenarios.
There was a problem hiding this comment.
Sure I have verified it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Result