Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.2 compatibility #1473

Closed
wants to merge 1 commit into from
Closed

Conversation

thomas-kl1
Copy link
Contributor

Summary

Fix following error on PHP8.2

1 exception(s):
Exception #0 (Exception): Deprecated Functionality: Creation of dynamic property Algolia\AlgoliaSearch\ViewModel\Recommend\Cart::$storeManager is deprecated in /var/www/project/magento/vendor/algolia/algoliasearch-magento-2/ViewModel/Recommend/Cart.php on line 42

Result

Add the storeManager property

@thomas-kl1
Copy link
Contributor Author

Hello @mohitalgolia @tarun-algolia @rachel-trott

Could you review this quickly? It's a major issue, the cart could not load and crash with PHP8.2.

@mohitalgolia
Copy link
Contributor

Thank you for the patch, @thomas-kl1. We've successfully reproduced the issue, and it will be incorporated into our upcoming release.

@thomas-kl1
Copy link
Contributor Author

Hello @mohitalgolia , any ETA on the next release date?

@rachel-trott
Copy link
Collaborator

@thomas-kl1 We are working on the next release and tentatively release will be end of February. Please use this as patch for now. Thank you for bringing this up.

@samsteele
Copy link

Please prioritise this it's a critical issue on the current Magento version, fixing this shouldn't take a month

@mohitalgolia
Copy link
Contributor

We have included this issue in our 3.13.1 release and uploaded to marketplace.

@thomas-kl1
Copy link
Contributor Author

@mohitalgolia quick question, why you copy-paste then close instead of just mergin this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants