Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search for facet values #1020

Merged
merged 5 commits into from Apr 19, 2018
Merged

Search for facet values #1020

merged 5 commits into from Apr 19, 2018

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Apr 9, 2018

No description provided.

@damcou damcou requested a review from JanPetr April 9, 2018 16:00
JanPetr
JanPetr suggested changes Apr 15, 2018
View reviewed changes
Copy link
Contributor

@JanPetr JanPetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @damcou! 👍
How about having the same border for search facet values input as the top search?
screenshot 2018-04-15 21 05 51
vs.
screenshot 2018-04-15 21 06 02

damcou
damcou commented Apr 16, 2018
View reviewed changes
Copy link
Contributor Author

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Borders of the inputs have been harmonized as requested.

@JanPetr JanPetr merged commit f30d99c into develop Apr 19, 2018
@JanPetr
Copy link
Contributor

JanPetr commented Apr 19, 2018

Nice work! 🚀 🙌

@JanPetr JanPetr deleted the facet-values-search branch February 14, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanPetr JanPetr JanPetr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@damcou @JanPetr