Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent backend rendering #886

Merged
merged 4 commits into from
Sep 28, 2017
Merged

Prevent backend rendering #886

merged 4 commits into from
Sep 28, 2017

Conversation

JanPetr
Copy link
Contributor

@JanPetr JanPetr commented Aug 4, 2017

This feature prevents category pages to be rendered on backed when they use Algolia. As a result the rendering should be much faster. Implements #877

TODO:

@alexgran
Copy link

alexgran commented Aug 9, 2017

Hi, works fine for me, even in heavily customised Apptha MArketplace based website.
I think we should use the same approach for product search?

@JanPetr
Copy link
Contributor Author

JanPetr commented Aug 11, 2017

Thanks @alexgran!
I removed few more templates from backend rendering including search page.

Can you confirm that everything still works on your side and that you can see a performance improvement?

Thank you!

@JanPetr
Copy link
Contributor Author

JanPetr commented Aug 24, 2017

Hello @alexgran,
did you have some time to try the latest changes in this PR?

@alexgran
Copy link

Hi @JanPetr , currently on holiday, but got a developer on the task. Will have feedback next week.

@JanPetr
Copy link
Contributor Author

JanPetr commented Aug 29, 2017

Thanks @alexgran, I'm looking forward!

@alexgran
Copy link

alexgran commented Sep 4, 2017

@JanPetr Works like a charm. On a non optimised development server, this gives around 50% improvment on the page with all products.

@JanPetr
Copy link
Contributor Author

JanPetr commented Sep 6, 2017

Thanks for your feedback @alexgran 💯

@JanPetr JanPetr force-pushed the feat/prevent_backend_rendering branch from be5fce2 to 5827607 Compare September 20, 2017 15:04
@JanPetr JanPetr merged commit 3c59704 into develop Sep 28, 2017
@JanPetr JanPetr deleted the feat/prevent_backend_rendering branch September 28, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants