Introduce: pass array argument to geoloc #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only a latitude & longitude couple could be passed to geoloc
Now, a large array in the form of:
`[{ lat: x_1, lng: y_1 }, ..., { lat: x_n, lng: y_n }]` can be passed,
through a block as below:
```
geoloc do
geoloc_array
end
```
Travis seems not be passing otherwise.
|
Hi @ldlgds2, thanks a lot for your PR! Would you mind adding some test to reflect your changes? Have a great day, |
|
Hi Chloe,
No problem!
Laurent de Saignes
… Le 2 janv. 2020 à 17:52, Chloe Liban ***@***.***> a écrit :
Hi @ldlgds2, thanks a lot for your PR! Would you mind adding some test to reflect your changes?
Have a great day,
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Hi Chloe,
I will however need a new API key for performing the tests, because I only could get a one-month trial from Algolia.
May you provide me with a temporary new one for testing purposes?
Best,
Laurent de Saignes
… Le 2 janv. 2020 à 11:44, Laurent de Saignes ***@***.***> a écrit :
Hi Chloe,
No problem!
Laurent de Saignes
> Le 2 janv. 2020 à 17:52, Chloe Liban ***@***.***> a écrit :
>
>
> Hi @ldlgds2 <https://github.com/ldlgds2>, thanks a lot for your PR! Would you mind adding some test to reflect your changes?
>
> Have a great day,
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <#372?email_source=notifications&email_token=AIAQQ3PXRD422GYWLNV4RJLQ3W2NHA5CNFSM4JSYODOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH57J5I#issuecomment-570160373>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIAQQ3MJHLGAGGZW6IJMLPTQ3W2NHANCNFSM4JSYODOA>.
>
|
|
Hi @ldlgds2 ! We don't provide API keys on the fly, but it's totally fine if you create a new application and use it for your new tests |
Altered model to accept arrays of coordinates as strings. Also, modified model. Last, added one test.
|
Hi @chloelbn !
It is now ready for review.
There seems to be a problem with Travis as some of the builds are not passing, but I was not able to determine what it is.
… Le 7 janv. 2020 à 18:33, Chloe Liban ***@***.***> a écrit :
Hi @ldlgds2 <https://github.com/ldlgds2> ! We don't provide API keys on the fly, but it's totally fine if you create a new application and use it for your new tests
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#372?email_source=notifications&email_token=AIAQQ3IXL64YMLU3MONINJ3Q4S4H7A5CNFSM4JSYODOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIJU3VY#issuecomment-571690455>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIAQQ3LNGTSCBNDDKKU5IZDQ4S4H7ANCNFSM4JSYODOA>.
|
For Travis CI re-run.
|
Hi @chloelbn,
I checked the Travis logs and the problem seems to be: The command "eval $(./algolia-keys export) && bundle exec rake" exited with 1.
May you fix this please?
The builds are passing locally, the problem thus comes from Travis CI.
… Le 27 janv. 2020 à 21:02, Laurent de Saignes ***@***.***> a écrit :
Hi @chloelbn !
It is now ready for review.
There seems to be a problem with Travis as some of the builds are not passing, but I was not able to determine what it is.
> Le 7 janv. 2020 à 18:33, Chloe Liban ***@***.*** ***@***.***>> a écrit :
>
> Hi @ldlgds2 <https://github.com/ldlgds2> ! We don't provide API keys on the fly, but it's totally fine if you create a new application and use it for your new tests
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <#372?email_source=notifications&email_token=AIAQQ3IXL64YMLU3MONINJ3Q4S4H7A5CNFSM4JSYODOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIJU3VY#issuecomment-571690455>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIAQQ3LNGTSCBNDDKKU5IZDQ4S4H7ANCNFSM4JSYODOA>.
>
|
For Travis CI re-build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only a latitude & longitude couple could be passed to geoloc
Now, a larger set in the array form of:
[{ lat: x_1, lng: y_1 }, ..., { lat: x_n, lng: y_n }]can be passed,through a block as below:
Describe your change
Still accept simple latitude & longitude passing, but also an array of several hashes containing different coordinates.
What problem is this fixing?
Array passing of multiple latitudes & longitudes.