Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check both Sequel and Sequel::Model are defined. #433

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Check both Sequel and Sequel::Model are defined. #433

merged 1 commit into from
Jun 14, 2023

Conversation

mikeastock
Copy link
Contributor

This resolves a conflict of using this gem with rodauth-rails and using ActiveRecord.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #...
Need Doc update no

Describe your change

Adds checks for Sequel::Model being defined.

What problem is this fixing?

While using this gem and rodauth-rails at the same time you get an

NameError (uninitialized constant Sequel::Model):

error because rodauth-rails loads Sequel but not Sequel::Model

This resolves a conflict of using this gem with `rodauth-rails` and
using ActiveRecord.
@mikeastock
Copy link
Contributor Author

CI failures seem to be unrelated to this change

@DevinCodes DevinCodes self-requested a review June 13, 2023 09:07
@DevinCodes
Copy link
Contributor

Hey @mikeastock , thank you for the contribution.

The CI failing is indeed linked to something else, no need to worry about it 😉
The PR looks good to me, I'll try to get a release out this week with this fix. I'll leave a comment on this PR once that's done.

Cheers!

@DevinCodes DevinCodes merged commit febfabf into algolia:master Jun 14, 2023
5 of 8 checks passed
@DevinCodes
Copy link
Contributor

Thanks again @mikeastock , this has been released in version 2.2.2: https://rubygems.org/gems/algoliasearch-rails/versions/2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants