feat(highlight): use helper from is.js instead of custom implementation #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
commented
Jan 25, 2022
|
✔️ Deploy Preview for angular-instantsearch ready! 🔨 Explore the source changes: 6361960 🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-instantsearch/deploys/61f14775ec18450008e38d04 😎 Browse the preview: https://deploy-preview-888--angular-instantsearch.netlify.app |
dhayab
commented
Jan 25, 2022
dhayab
requested review from
a team,
sarahdayan and
Haroenv
and removed request for
a team
Haroenv
reviewed
Jan 25, 2022
Haroenv
reviewed
Jan 25, 2022
Haroenv
reviewed
Jan 25, 2022
Haroenv
approved these changes
Jan 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the implementation of
<ais-highlight>to directly use the helper from InstantSearch.js and normalize the behaviour between the two flavours.Result
<ais-highlight>now supports thetagNameproperty. To prevent breaking changes, and until this is added back to IS.js, there is still a custom fallback logic (it returns the unhighlighted attribute value when it exists but is not in_highlightResult).