feat: add <ais-reverse-highlight>, <ais-snippet> and <ais-reverse-snippet> components
#891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
changed the title
<ais-reverse-highlight>, <ais-snippet> and <ais-reverse-snippet> components
dhayab
requested review from
a team,
sarahdayan and
Haroenv
and removed request for
a team
|
✔️ Deploy Preview for angular-instantsearch ready! 🔨 Explore the source changes: 21d05ac 🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-instantsearch/deploys/61f174c3b5d3410008ae1cb1 😎 Browse the preview: https://deploy-preview-891--angular-instantsearch.netlify.app |
Haroenv
approved these changes
Jan 26, 2022
|
@dhayab I took the freedom to update the base of this PR to |
dhayab
changed the title
<ais-reverse-highlight>, <ais-snippet> and <ais-reverse-snippet> components<ais-reverse-highlight> / <ais-snippet> / <ais-reverse-snippet> components
dhayab
changed the title
<ais-reverse-highlight> / <ais-snippet> / <ais-reverse-snippet> components<ais-reverse-highlight>, <ais-snippet> and <ais-reverse-snippet> components
|
It looks like the CI is stuck, and the renaming trick does not force a rerun. The ci/circleci: build job was successfully run with the latest commit, I believe we're safe if we force squash + merge this. Wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on the work in #888 , here are three additions to the component library:
<ais-reverse-highlight><ais-snippet><ais-reverse-snippet>Contrary to the update of
<ais-highlight>, they follow more closely the naming set by the helpers in InstantSearch.js (specifically thehighlightedTagNameparameter). The next major update of Angular InstantSearch will probably be an opportunity to bring back this change to<ais-highlight>as well.