feat(search-box): add loading indicator + showLoadingIndicator prop
#962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for angular-instantsearch ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work Item : FX-377
To stay as close as
InstantSearch.js's interface as possible, we decided to add ashowLoadingIndicatorprop which istrueby default.The only difference is that we are not able to provide a custom component, which is not feasible for submit/reset buttons anyway.
Result
By default, when search is stalled, the reset button will be hidden, and a loading indicator is shown.
If
showLoadingIndicatoris set to false, it will never show a loading indicator, and the reset button will still be present if search is stalled.