Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v4): upgrade InstantSearch and co #821

Merged
merged 6 commits into from
Jul 13, 2021
Merged

chore(v4): upgrade InstantSearch and co #821

merged 6 commits into from
Jul 13, 2021

Conversation

tkrugg
Copy link
Contributor

@tkrugg tkrugg commented Jul 12, 2021

Summary

This PR updates instantsearch.js, the client and the helper to their latest versions + some minor type tweaking and peer dependencies added (storybook)

@tkrugg tkrugg changed the title Chore/v4 update is hore(deps): upgrade InstantSearch and co Jul 12, 2021
@tkrugg tkrugg changed the title hore(deps): upgrade InstantSearch and co chore(v4): upgrade InstantSearch and co Jul 12, 2021
@tkrugg tkrugg requested review from a team, eunjae-lee and francoischalifour and removed request for a team July 12, 2021 19:42
@netlify
Copy link

netlify bot commented Jul 12, 2021

✔️ Deploy Preview for angular-instantsearch ready!

🔨 Explore the source changes: f42d10c

🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-instantsearch/deploys/60ec9ab81e8ebb00082e4f6c

😎 Browse the preview: https://deploy-preview-821--angular-instantsearch.netlify.app

@netlify
Copy link

netlify bot commented Jul 12, 2021

✔️ Deploy Preview for angular-instantsearch ready!

🔨 Explore the source changes: 0e3bd3d

🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-instantsearch/deploys/60edd4d4704a290007e4a0d4

😎 Browse the preview: https://deploy-preview-821--angular-instantsearch.netlify.app

"algoliasearch": "4.4.0",
"angular-instantsearch": "3.0.0-beta.1",
"algoliasearch": "4.10.3",
"angular-instantsearch": "file:../../dist",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this have an impact for the e2e test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like e2e tests are running on angular examples. So I guess the answer is no 😄 .
We'll fix this at a later point.

The examples run fine however: https://deploy-preview-821--angular-instantsearch.netlify.app/examples/e-commerce/
And it's much easier to test the current commit of the lib this way. Not sure why we haven't done it earlier.

examples/storybook/src/custom-widgets.ts Outdated Show resolved Hide resolved
Co-authored-by: Haroen Viaene <hello@haroen.me>
@tkrugg tkrugg merged commit 39bec5e into v4 Jul 13, 2021
@tkrugg tkrugg deleted the chore/v4_update_is branch July 13, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants