-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v4): upgrade InstantSearch and co #821
Conversation
f42d10c
to
609cd43
Compare
✔️ Deploy Preview for angular-instantsearch ready! 🔨 Explore the source changes: f42d10c 🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-instantsearch/deploys/60ec9ab81e8ebb00082e4f6c 😎 Browse the preview: https://deploy-preview-821--angular-instantsearch.netlify.app |
✔️ Deploy Preview for angular-instantsearch ready! 🔨 Explore the source changes: 0e3bd3d 🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-instantsearch/deploys/60edd4d4704a290007e4a0d4 😎 Browse the preview: https://deploy-preview-821--angular-instantsearch.netlify.app |
"algoliasearch": "4.4.0", | ||
"angular-instantsearch": "3.0.0-beta.1", | ||
"algoliasearch": "4.10.3", | ||
"angular-instantsearch": "file:../../dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this have an impact for the e2e test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like e2e tests are running on angular examples. So I guess the answer is no 😄 .
We'll fix this at a later point.
The examples run fine however: https://deploy-preview-821--angular-instantsearch.netlify.app/examples/e-commerce/
And it's much easier to test the current commit of the lib this way. Not sure why we haven't done it earlier.
Co-authored-by: Haroen Viaene <hello@haroen.me>
Summary
This PR updates
instantsearch.js
, the client and the helper to their latest versions + some minor type tweaking and peer dependencies added (storybook)