Skip to content

Commit

Permalink
fix(javascript): release process (#2106)
Browse files Browse the repository at this point in the history
  • Loading branch information
shortcuts committed Oct 11, 2023
1 parent 275620f commit 2c58dea
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion config/generation.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ export const patterns = [
'!clients/algoliasearch-client-javascript/.yarn/**',
'!clients/algoliasearch-client-javascript/scripts/**',
'!clients/algoliasearch-client-javascript/tests/**',
'clients/algoliasearch-client-javascript/packages/**/package.json',
// the release process is allowed to push changes to this file, but in general we don't because those files are generated
process.env.RELEASE ? '!clients/algoliasearch-client-javascript/packages/**/package.json' : 'clients/algoliasearch-client-javascript/packages/**/package.json',
'!clients/algoliasearch-client-javascript/packages/requester-*/**',
'!clients/algoliasearch-client-javascript/packages/client-common/**',
'!clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/**',
Expand Down
4 changes: 2 additions & 2 deletions scripts/release/createReleasePR.ts
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ async function prepareGitEnvironment(): Promise<void> {
console.log('Pulling from origin...');
await run('git fetch origin');
await run('git fetch --tags --force');
await run('git pull');
await run('git pull origin $(git branch --show-current)');
}

async function createReleasePR(): Promise<void> {
Expand Down Expand Up @@ -415,7 +415,7 @@ async function createReleasePR(): Promise<void> {
if (process.env.LOCAL_TEST_DEV) {
await run(`git commit -m "${commitMessage} [skip ci]"`);
} else {
await run(`CI=false git commit -m "${commitMessage}"`);
await run(`CI=false RELEASE=true git commit -m "${commitMessage}"`);
}

// cleanup all the changes to the generated files (the ones not commited because of the pre-commit hook)
Expand Down

0 comments on commit 2c58dea

Please sign in to comment.