Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): predict model endpoints #1014

Merged
merged 11 commits into from
Sep 14, 2022
Merged

feat(specs): predict model endpoints #1014

merged 11 commits into from
Sep 14, 2022

Conversation

writeens
Copy link
Contributor

@writeens writeens commented Sep 13, 2022 •
edited
Loading

🧭 What and Why

Creating model methods for Predict client.

🎟 JIRA Ticket: PRED-567

Changes included:

  • Create activateModelInstance method
  • Create deleteModelInstance method
  • Create getAvailableModelTypes method
  • Create getListModelInstance method
  • Create getModelInstanceConfig method
  • Create getModelMetrics method

🧪 Test

  • Setup CTS tests for methods

@writeens writeens requested a review from a team as a code owner September 13, 2022 11:44
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 13, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@writeens writeens self-assigned this Sep 13, 2022
@netlify
Copy link

netlify bot commented Sep 13, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 9658ea3
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63206d0d097d8b0008bfc5ae
😎 Deploy Preview https://deploy-preview-1014--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 13, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 947fabc
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6321a8a5729d0f000975c7d5
😎 Deploy Preview https://deploy-preview-1014--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bengreenbank
bengreenbank reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@bengreenbank bengreenbank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

bengreenbank
bengreenbank previously approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@bengreenbank bengreenbank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

shortcuts
shortcuts reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) I made some recommendations for the codegen part

specs/predict/common/schemas/modelsParams.yml Show resolved Hide resolved
specs/predict/paths/models/models.yml Outdated Show resolved Hide resolved
specs/predict/paths/models/modelInstances.yml Show resolved Hide resolved
shortcuts
shortcuts approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Should I release once this PR is merged?

@writeens
Copy link
Contributor Author

Yeah sure...Good to go

@shortcuts shortcuts merged commit bf539a7 into main Sep 14, 2022
@shortcuts shortcuts deleted the feat/predict-model-endpoints branch September 14, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@bengreenbank bengreenbank bengreenbank left review comments

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@writeens writeens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@writeens @algolia-bot @shortcuts @bengreenbank