Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): update model response #1034

Merged
merged 1 commit into from
Sep 22, 2022
Merged

fix(specs): update model response #1034

merged 1 commit into from
Sep 22, 2022

Conversation

writeens
Copy link
Contributor

@writeens writeens commented Sep 22, 2022 •
edited
Loading

🧭 What and Why

Update Predict models response properties to avoid naming conflicts

Changes included:

  • Change from error to errorMessage
  • Change from status to modelStatus

🧪 Test

  • CTS tests remain unchanged for methods

@writeens writeens requested a review from a team as a code owner September 22, 2022 14:16
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 22, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@netlify
Copy link

netlify bot commented Sep 22, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 1d91918
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/632c6e2c2ea8b60008a6bf4a
😎 Deploy Preview https://deploy-preview-1034--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shortcuts shortcuts merged commit 09a235c into main Sep 22, 2022
@shortcuts shortcuts deleted the feat/update-model-parameters branch September 22, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@bengreenbank bengreenbank bengreenbank approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@francoischalifour francoischalifour Awaiting requested review from francoischalifour

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@writeens @algolia-bot @shortcuts @bengreenbank