Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(javascript): create ingestion client #1101

Merged
merged 14 commits into from
Dec 13, 2022
Merged

feat(javascript): create ingestion client #1101

merged 14 commits into from
Dec 13, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 23, 2022

🧭 What and Why

Create the ingestion JavaScript API client, useful for the AppEx team, and for us to test the API.

Changes included:

  • The ingestion API does not support query params so I had to remove the algolia user agent for it, but maybe we should allow user agent on this API in the future.
  • Added a playground
  • Handle void return type

🧪 Test

There is no CTS yet, will come in a later PR.

@millotp millotp self-assigned this Oct 23, 2022
@millotp millotp requested a review from a team as a code owner October 23, 2022 10:01
@millotp millotp requested review from damcou and shortcuts and removed request for a team October 23, 2022 10:01
@netlify
Copy link

netlify bot commented Oct 23, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 8a27c9c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6398a4b2f31c80000906e25f

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 23, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Base automatically changed from feat/ingestion-client to main December 12, 2022 17:22
shortcuts
shortcuts reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it! we are still missing a lot of description on the spec side but it's good enough for now!

config/openapitools.json Outdated Show resolved Hide resolved
@millotp @shortcuts
Update config/openapitools.json
8a27c9c 
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
@millotp millotp enabled auto-merge (squash) December 13, 2022 16:23
@millotp millotp enabled auto-merge (squash) December 13, 2022 16:23
@millotp millotp merged commit deac88b into main Dec 13, 2022
@millotp millotp deleted the feat/ingestion-js branch December 13, 2022 16:27
@millotp millotp mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@millotp @algolia-bot @shortcuts