Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add query params to task lists endpoint in Ingestion APIC #1233

Merged
merged 3 commits into from
Jan 16, 2023
Merged

feat(specs): add query params to task lists endpoint in Ingestion APIC #1233

merged 3 commits into from
Jan 16, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jan 13, 2023 •
edited by jira bot

🧭 What and Why

🎟 JIRA Ticket: DI-826

Changes included:

Add query param filtering to task list endpoint in the ingestion API client

@Fluf22 Fluf22 requested a review from a team as a code owner January 13, 2023 15:58
@Fluf22 Fluf22 self-assigned this Jan 13, 2023
@Fluf22 Fluf22 requested review from damcou and millotp January 13, 2023 15:58
@netlify
Copy link

netlify bot commented Jan 13, 2023 •
edited

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 46fa260
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63c5244cd6d4cb0008e856aa
😎 Deploy Preview https://deploy-preview-1233--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 13, 2023 •
edited

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 changed the title feat(tasks): add query params to task lists endpoint feat(specs): add query params to task lists endpoint Jan 13, 2023
@Fluf22 Fluf22 changed the title feat(specs): add query params to task lists endpoint feat(specs): add query params to task lists endpoint in Ingestion APIC Jan 13, 2023
millotp
millotp reviewed Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice thanks for your first contribution !
I think in this case the description could be more precise, maybe put them in another file like taskParameters.yml

specs/ingestion/common/parameters.yml Outdated Show resolved Hide resolved
specs/ingestion/common/parameters.yml Outdated Show resolved Hide resolved
millotp
millotp approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@millotp millotp merged commit 4b1f1fd into main Jan 16, 2023
@millotp millotp deleted the feat/task-list-qp branch January 16, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fluf22 @algolia-bot @millotp