Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add query param to filter list endpoint results #1245

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jan 19, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-837

Changes included:

Add query param filtering to lists endpoint in the ingestion API client:

  • sources
  • destinations
  • authentications

@Fluf22 Fluf22 requested a review from a team as a code owner January 19, 2023 11:16
@Fluf22 Fluf22 self-assigned this Jan 19, 2023
@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 3c0a278
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63c95bec2688350009932895
😎 Deploy Preview https://deploy-preview-1245--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 19, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great :)

specs/ingestion/common/authenticationParameters.yml Outdated Show resolved Hide resolved
@Fluf22 Fluf22 requested a review from shortcuts January 19, 2023 14:27
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

makes me think we still name list endpoints with get prefix here, idk if we want to make it match our internal naming 🤔

@shortcuts shortcuts merged commit 700dad6 into main Jan 19, 2023
@shortcuts shortcuts deleted the feat/list-filter-qp branch January 19, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants