Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add more descriptions to the Ingestion API #1273

Merged
merged 23 commits into from
Jan 31, 2023
Merged

feat(specs): add more descriptions to the Ingestion API #1273

merged 23 commits into from
Jan 31, 2023

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jan 30, 2023 •
edited

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-893

Changes included:

This PR adds some description to the Ingestion API.

@netlify
Copy link

netlify bot commented Jan 30, 2023 •
edited

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit a89d92c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63d91e89c21b5b0007e15840
😎 Deploy Preview https://deploy-preview-1273--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 30, 2023 •
edited

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts marked this pull request as ready for review January 31, 2023 11:53
@shortcuts shortcuts requested a review from a team as a code owner January 31, 2023 11:53
@shortcuts shortcuts changed the title chore: add more descriptions to the Ingestion API feat(specs): add more descriptions to the Ingestion API Jan 31, 2023
@shortcuts shortcuts enabled auto-merge (squash) January 31, 2023 12:09
millotp
millotp reviewed Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work thank you !

specs/ingestion/common/schemas/destination.yml Show resolved Hide resolved
specs/ingestion/common/schemas/event.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/task.yml Outdated Show resolved Hide resolved
specs/ingestion/common/sourceParameters.yml Outdated Show resolved Hide resolved
specs/ingestion/paths/runs/events/events.yml Outdated Show resolved Hide resolved
specs/ingestion/paths/runs/events/events.yml Outdated Show resolved Hide resolved
specs/ingestion/paths/runs/tasks/taskID.yml Outdated Show resolved Hide resolved
specs/ingestion/spec.yml Show resolved Hide resolved
specs/ingestion/spec.yml Show resolved Hide resolved
millotp
millotp approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@shortcuts
Copy link
Member Author

nice !

thanks for helping!

@shortcuts shortcuts merged commit aed20fe into main Jan 31, 2023
@shortcuts shortcuts deleted the chore/add-descriptions-for-ingestion branch January 31, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@millotp millotp

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shortcuts @algolia-bot @millotp