Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): source update changes #1276

Merged
merged 4 commits into from
Jan 31, 2023
Merged

feat(specs): source update changes #1276

merged 4 commits into from
Jan 31, 2023

Conversation

mehmetaligok
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-827

Changes included:

  • SourceUpdate endpoint changed to put
  • SourceUpdate input ref fixed

@netlify
Copy link

netlify bot commented Jan 30, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 53e29b6
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63d8e683f2658e000aeeef6c
😎 Deploy Preview https://deploy-preview-1276--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mehmetaligok mehmetaligok self-assigned this Jan 30, 2023
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 30, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@mehmetaligok mehmetaligok marked this pull request as ready for review January 30, 2023 16:43
@mehmetaligok mehmetaligok requested a review from a team as a code owner January 30, 2023 16:43
shortcuts
shortcuts reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great :)

specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
shortcuts
shortcuts approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@shortcuts shortcuts merged commit 859c0a9 into main Jan 31, 2023
@shortcuts shortcuts deleted the feat/source-update-changes branch January 31, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@mehmetaligok mehmetaligok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mehmetaligok @algolia-bot @shortcuts