Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): monorepo #131

Merged
merged 4 commits into from
Feb 10, 2022
Merged

feat(javascript): monorepo #131

merged 4 commits into from
Feb 10, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Feb 10, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-307

Changes included:

This PR is the first step of https://algolia.atlassian.net/browse/APIC-232 but introduces many unreleated changes to the bundling.

As of now, our algoliasearch-client-javascript folder was just a folder-of-folders, it now hosts the same structure as the actual repo.

  • Move clients and utils to a packages/ folder
  • Remove .gitignore and update tsconfigs to match global one.
  • Remove exports of @algolia/client-common from packages as it's a dependency.
  • Remove unused deps from JavaScript tests

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Feb 10, 2022
@shortcuts
Copy link
Member Author

shortcuts commented Feb 10, 2022

(Sorry for the unrelated createMemoryCache change, I might have fail a checkout 🤔 will remove it)

@shortcuts shortcuts force-pushed the feat/javascript-client-monorepo branch from 9389cf4 to 6a75c0a Compare February 10, 2022 14:57
@shortcuts shortcuts marked this pull request as ready for review February 10, 2022 14:58
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ! Almost ready to deploy

.github/actions/cache/action.yml Outdated Show resolved Hide resolved
clients/algoliasearch-client-javascript/tsconfig.json Outdated Show resolved Hide resolved
scripts/builds/clients.sh Show resolved Hide resolved
@shortcuts shortcuts enabled auto-merge (squash) February 10, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants