Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): update Predict Segment operators to textual format #1316

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

francoischalifour
Copy link
Member

@francoischalifour francoischalifour commented Feb 15, 2023

🧭 What and Why

Since the API client generator tool doesn't support > symbol as keys, we decided to use the GT syntax both in the API client and in the Predict REST API.

This PR updates symbol operators like "=" to textual operators like "EQ".

Changes included:

  • Updated the probability filters to use textual operators like "EQ"
  • Updated all operators to uppercase
  • Remove operator converter introduced in e1c61be (#1202)

🧪 Test

  • Added test with filter probability

Related

@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 8a1e053
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63ecb937f75aeb0008e1bcb4
😎 Deploy Preview https://deploy-preview-1316--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 15, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

bengreenbank
bengreenbank previously approved these changes Feb 15, 2023
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@shortcuts shortcuts merged commit 2eca9b7 into main Feb 15, 2023
@shortcuts shortcuts deleted the fix/predict-operator-textual-representation branch February 15, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants