fix(javascript): prevent conflict with version variable
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
a team and
damcou
and removed request for
a team
bodinsamuel
approved these changes
Feb 17, 2022
Actually exposing the version is only good for testing, I'm not sure if there is other use cases, but I'll keep this one exported for now and inline it later if unused |
|
this can be helpful for consumer for whatever purpose, I would keep it exposed |
This was referenced Feb 18, 2022
This was referenced Feb 28, 2022
This was referenced Feb 28, 2022
This was referenced Mar 22, 2022
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
The
versionvariable can conflict with API method parameters, see #140 for an exampleChanges included:
Rename exported
versiontoapiClientVersion.🧪 Test
CI :D