Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add lastUpdatedAt field to predict segments #1431

Merged
merged 4 commits into from
Apr 3, 2023
Merged

feat(specs): add lastUpdatedAt field to predict segments #1431

merged 4 commits into from
Apr 3, 2023

Conversation

bengreenbank
Copy link
Contributor

@bengreenbank bengreenbank commented Mar 30, 2023 •
edited
Loading

🧭 What and Why

Adds the last updated date and time to be consistent with other data structures in Predict.

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/PRED-1281
API PR: https://github.com/algolia/predict-api/pull/97

To be released only once the API is live with the new changes.

Changes included:

  • Add lastUpdatedAt to segments
  • Edit description of updatedAt in segments to distinguish between the two

🧪 Test

n/a

@bengreenbank bengreenbank self-assigned this Mar 30, 2023
@netlify
Copy link

netlify bot commented Mar 30, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit c3c1e68
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/642af26b0c353b000842840a
😎 Deploy Preview https://deploy-preview-1431--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 30, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@bengreenbank bengreenbank changed the title feat(specs): add lastUpdatedAt field to predict segments feat(specs): add lastUpdatedAt field to predict segments Mar 30, 2023
@bengreenbank bengreenbank marked this pull request as ready for review March 31, 2023 10:06
@bengreenbank bengreenbank requested a review from a team as a code owner March 31, 2023 10:06
shortcuts
shortcuts previously approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great :)

writeens
writeens previously approved these changes Mar 31, 2023
View reviewed changes
@shortcuts
Copy link
Member

is it good to go? the pr body feels like it's not

@bengreenbank
Copy link
Contributor Author

is it good to go? the pr body feels like it's not

No, we plan to release the API some time next week.

I'll comment on this PR once it's ready.

francoischalifour
francoischalifour previously approved these changes Mar 31, 2023
View reviewed changes
specs/predict/responses/Segment.yml Outdated
@@ -108,6 +111,11 @@ segmentName:
description: The name of the segment.

updatedAt:
type: string
description: The date and time at which the segment was successfully updated (RFC3339).
Copy link
Member

@francoischalifour francoischalifour Mar 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "successfully" needed? updatedAt wouldn't get updated if the segment processing turns its status to "failed", is that it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5c3cd7e

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Discussed on Slack) Yes, you are correct. updatedAt is only ever used in the response to a create or update segment request (not used by the pipeline).

@bengreenbank
Copy link
Contributor Author

Hey @shortcuts, we are ready to release! Thanks!

@shortcuts shortcuts enabled auto-merge (squash) April 3, 2023 15:36
@shortcuts
Copy link
Member

noice :)

@shortcuts shortcuts merged commit 33ec7bc into main Apr 3, 2023
@shortcuts shortcuts deleted the feat/predict/segment-last-updated-at branch April 3, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoischalifour francoischalifour francoischalifour approved these changes

@shortcuts shortcuts shortcuts approved these changes

@writeens writeens writeens left review comments

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@mehmetaligok mehmetaligok Awaiting requested review from mehmetaligok mehmetaligok is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@bengreenbank bengreenbank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bengreenbank @algolia-bot @shortcuts @francoischalifour @writeens