Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): add bigquery to sourceTypes enum #1490

Merged
merged 4 commits into from
Apr 28, 2023
Merged

feat(clients): add bigquery to sourceTypes enum #1490

merged 4 commits into from
Apr 28, 2023

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Apr 28, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-1034

Changes included:

  • added bigquery to sourceTypes enum

@damcou damcou requested a review from a team as a code owner April 28, 2023 13:56
@damcou damcou requested review from aallam and millotp April 28, 2023 13:56
@netlify
Copy link

netlify bot commented Apr 28, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 7da9a62
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/644bd5e10c056e000885e564
😎 Deploy Preview https://deploy-preview-1490--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 28, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp
Copy link
Collaborator

millotp commented Apr 28, 2023

you need to add the SourceBigQuery alongside

@millotp millotp changed the title feat(ingestion): add bigquery to sourceTypes enum feat(specs): add bigquery to sourceTypes enum Apr 28, 2023
@damcou damcou changed the title feat(specs): add bigquery to sourceTypes enum feat(clients): add bigquery to sourceTypes enum Apr 28, 2023
@damcou
Copy link
Contributor Author

damcou commented Apr 28, 2023

you need to add the SourceBigQuery alongside

Here you go

millotp
millotp approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@damcou damcou enabled auto-merge (squash) April 28, 2023 14:20
@damcou damcou merged commit 44962fa into main Apr 28, 2023
17 checks passed
@damcou damcou deleted the feat/DI-1034/add-bigquery-sourceType branch April 28, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@aallam aallam Awaiting requested review from aallam aallam is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@damcou @algolia-bot @millotp