Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add reason code to run outcome #1531

Merged
merged 3 commits into from
May 9, 2023
Merged

feat(specs): add reason code to run outcome #1531

merged 3 commits into from
May 9, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented May 9, 2023 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1218

Changes included:

  • add reason code
  • list possible values in the enum

@Fluf22 Fluf22 self-assigned this May 9, 2023
@Fluf22 Fluf22 requested a review from a team as a code owner May 9, 2023 09:09
@Fluf22 Fluf22 requested review from damcou and millotp May 9, 2023 09:09
@netlify
Copy link

netlify bot commented May 9, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 4e88421
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/645a0dd6bca556000896275a
😎 Deploy Preview https://deploy-preview-1531--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 9, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Fluf22 Fluf22 enabled auto-merge (squash) May 9, 2023 09:15
@Fluf22 Fluf22 merged commit 7c9cfb9 into main May 9, 2023
18 checks passed
@Fluf22 Fluf22 deleted the feat/add-reason-code branch May 9, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fluf22 @algolia-bot @millotp