-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): ingestion partial update method changed to patch #1564
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have both methods available, right? otherwise it's a breaking change
For the generated client-wise, it shouldn't be a breaking change for now. Since we are only changing the HTTP method, the name and all the parameters will be the same. For example, usage will stay as for the documentation part we will only show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I thought it was changing the method names, then it should be :okidoki:
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1280
Ingestion partial updates will use
PATCH
instead ofPUT
.Changes included:
PUT
method changed toPATCH
for partial updates.