Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): add docker source input #1594

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix(specs): add docker source input #1594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 43 additions & 2 deletions specs/ingestion/common/schemas/source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ SourceSearch:

SourceType:
type: string
enum: ['bigcommerce', 'commercetools', 'json', 'csv', 'bigquery']
enum: ['bigcommerce', 'commercetools', 'json', 'csv', 'bigquery', 'docker']

SourceCommercetools:
type: object
Expand Down Expand Up @@ -225,19 +225,59 @@ SourceBigQuery:
$ref: '#/UniqueIDColumn'
required:
- projectID
- datasetID
- datasetID

BigQueryDataType:
type: string
enum: ['ga4', 'ga360']

SourceDocker:
type: object
additionalProperties: false
properties:
registry:
$ref: '#/DockerRegistry'
image:
type: string
description: The name of the image to pull.
example: algolia/zendesk
version:
type: string
description: The version of the image, defaults to `latest`.
example: v2.1.0
imageType:
$ref: '#/DockerImageType'
outputFile:
type: string
description: The full name of the output file.
example: output.json
configuration:
type: object
description: The configuration of the spec.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say that's a JSON schema?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there for the API client ? where is it stored ?

required:
- registry
- image
- imageType
- configuration

DockerRegistry:
type: string
enum: ['dockerhub', 'gcr']
description: The registry where the image is stored.

DockerImageType:
type: string
enum: ['singer', 'custom', 'airbyte']
description: The type of the image.

SourceInput:
oneOf:
- $ref: '#/SourceCommercetools'
- $ref: '#/SourceBigCommerce'
- $ref: '#/SourceJSON'
- $ref: '#/SourceCSV'
- $ref: '#/SourceBigQuery'
- $ref: '#/SourceDocker'

SourceUpdateCommercetools:
type: object
Expand All @@ -261,3 +301,4 @@ SourceUpdateInput:
- $ref: '#/SourceJSON'
- $ref: '#/SourceCSV'
- $ref: '#/SourceBigQuery'
- $ref: '#/SourceDocker'
Loading