Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): waitForApiKey helper #1598

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

The logic was somehow inverted in order to determine if the key had been updated or not.

@shortcuts shortcuts requested a review from a team as a code owner June 6, 2023 12:52
@shortcuts shortcuts self-assigned this Jun 6, 2023
@shortcuts shortcuts requested review from damcou and aallam June 6, 2023 12:52
@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 69c5001
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/647f2bfa86a2a70008e0faaa
😎 Deploy Preview https://deploy-preview-1598--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 6, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shortcuts shortcuts merged commit 31f1050 into main Jun 6, 2023
19 checks passed
@shortcuts shortcuts deleted the fix/waitForApiKey-javascript branch June 6, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants