fix(javascript): release process #1779
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| @@ -15,7 +15,7 @@ | |||
| "folder": "clients/algoliasearch-client-javascript", | |||
| "npmNamespace": "@algolia", | |||
| "gitRepoId": "algoliasearch-client-javascript", | |||
| "utilsPackageVersion": "5.0.0-alpha.73", | |||
There was a problem hiding this comment.
are you sure you want to rename that ? I think utilsPackageVersion was fine, especially since we use this variable name elsewhere still
There was a problem hiding this comment.
bah we were populating this version with the search client version, we know they will always be in sync so.. I thought it was easier
There was a problem hiding this comment.
maybe rename it to searchPackageVersion ? just to differentiate from ingestion and the other
There was a problem hiding this comment.
or wdyt if I go with version so it's broader and cover many cases?
for JS it only concerns the utils package, but for the other clients it concerns the package itself
There was a problem hiding this comment.
version is fine, js will always have edge cases anyway
| @@ -36,53 +36,3 @@ After a full CI run, a release commit will be sent to every repository and sprea | |||
|
|
|||
| Each language repository should have their own release process, and should run only when the latest commit starts with `chore: release`. By doing so, we have a way to just update the repository, for example READMEs, without having to release. | |||
|
|
|||
| ## Releasing manually | |||
There was a problem hiding this comment.
we are going stable soon and there's many way to release, even from the CI, we don't have to communicate how to do that and shouldn't recommend it
There was a problem hiding this comment.
I think it could be nice to keep this as internal doc somewhere
| @@ -36,53 +36,3 @@ After a full CI run, a release commit will be sent to every repository and sprea | |||
|
|
|||
| Each language repository should have their own release process, and should run only when the latest commit starts with `chore: release`. By doing so, we have a way to just update the repository, for example READMEs, without having to release. | |||
|
|
|||
| ## Releasing manually | |||
There was a problem hiding this comment.
I think it could be nice to keep this as internal doc somewhere
clients/algoliasearch-client-dart/packages/client_core/lib/src/version.dart
Outdated
Show resolved
Hide resolved
|
ah Go is broken brb |
This reverts commit 34b999f.
|
ok actually we've named it |
|
ok 0 changes now it's perfect, time to try a release and see if it works |
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
fixes #1778
somehow the release process of the JavaScript client is broken (see #1778), it made me think that we could just leverage lerna for independant version bumping and remove any kind of JS-specific logic in the release bumping script.
to properly test this change, we can run
yarn docker:releaselocally to see every packages getting bumped, then run the generation and cts generation to assert it works properly.detailed changes
package.jsonoutputfield of theclients/openapitools.jsonfileupdateDartPackagescall to theupdateAPIVersionsmethoddart pub getto prevent dart cache issue on release